Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt indexer to ts-rs exported interfaces #921

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat: adapt indexer to ts-rs exported interfaces #921

merged 4 commits into from
Feb 12, 2024

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Jan 29, 2024 •
edited
Loading

Description

The #919, #920 need to go in first. Then I will rebase this.
This PR removes all the any that could be replaced by our auto-generated interfaces/types.
Now the jsonrpc calls is expecting the proper request and gives proper response. So when the structure changes we will know.

Motivation and Context

How Has This Been Tested?

Running dan-testing with a wallet with some accounts and transactions.

What process can a PR reviewer use to test or verify this change?

Same as above, maybe there is something I haven't tested (looked at). But at the first glance it's working as expected.

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@ghpbot-tari-project ghpbot-tari-project added CR-too_long P-conflicts The PR has merge conflicts that need to be resolved P-acks_required P-reviews_required labels Jan 29, 2024
@Cifko Cifko mentioned this pull request Jan 30, 2024
Merged
3 tasks
@ghpbot-tari-project ghpbot-tari-project removed the P-conflicts The PR has merge conflicts that need to be resolved label Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Test Results (CI)

80 tests   - 356   79 ✅  - 357   1h 52m 48s ⏱️ + 4m 37s
17 suites  -  40    0 💤 ±  0 
 1 files    -   1    1 ❌ +  1 

For more details on these failures, see this check.

Results for commit 9234b01. ± Comparison against base commit 704fef0.

This pull request removes 357 and adds 1 tests. Note that renamed tests count towards both. 
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:89:5
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:6:3
Scenario: Claim validator fees: tests/features/claim_fees.feature:6:3
Scenario: Confidential transfer to unexisting account: tests/features/transfer.feature:163:3
Scenario: Counter template registration and invocation: tests/features/counter.feature:7:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:7:5
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:133:5
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:73:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:44:3
Scenario: Indexer GraphQL requests events over network substate indexing: tests/features/indexer.feature:118:3
…

tari_base_node_client ‑ types::export_bindings_validatornode

♻️ This comment has been updated with latest results.

sdbondi
sdbondi approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sdbondi sdbondi enabled auto-merge February 12, 2024 13:38
@sdbondi sdbondi added this pull request to the merge queue Feb 12, 2024
Merged via the queue into tari-project:development with commit a3f3135 Feb 12, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
CR-too_long P-acks_required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cifko @sdbondi @ghpbot-tari-project